Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java and node agents in the e2e #11535

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Update Java and node agents in the e2e #11535

merged 5 commits into from
Nov 13, 2023

Conversation

wu-sheng
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added test Test requirements about performance, feature or before release. dependencies Pull requests that update a dependency file labels Nov 13, 2023
@wu-sheng wu-sheng added this to the 9.7.0 milestone Nov 13, 2023
@wu-sheng wu-sheng requested a review from a team November 13, 2023 06:25
wankai123
wankai123 previously approved these changes Nov 13, 2023
@wu-sheng
Copy link
Member Author

NodeJS tesr fail. @kezhenxu94 take a look?

@kezhenxu94
Copy link
Member

 - 	map[interface{}]interface{}{
 - 		string("id"):   string("cHJvdmlkZXI=.1_L3VzZXJz"),
 - 		string("name"): string("/users"),
 - 	},
 + 	map[interface{}]interface{}{
 + 		string("id"):   string("cHJvdmlkZXI=.1_UE9TVDovdXNlcnM="),
 + 		string("name"): string("POST:/users"),
 + 	},

NodeJS operation name was reformatted to include the method as prefix, you need to adjust the test expected data

@wu-sheng wu-sheng requested a review from wankai123 November 13, 2023 14:06
@wu-sheng wu-sheng merged commit 965dea8 into master Nov 13, 2023
163 checks passed
@wu-sheng wu-sheng deleted the wu-sheng-patch-1 branch November 13, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants